Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same pkg name in extensions #18

Closed
frezbo opened this issue Apr 2, 2024 · 3 comments
Closed

Same pkg name in extensions #18

frezbo opened this issue Apr 2, 2024 · 3 comments
Assignees

Comments

@frezbo
Copy link
Member

frezbo commented Apr 2, 2024

When trying to publish an official extension using this repo siderolabs/extensions#348 the ci fails since this repo's container image is named talos-vmtoolsd and extensions also has it named as talos-vmtoolsd. We have some options to mitigate this:

  • rename the image here to have some prefix/suffic like talos-vmtoolsd-pkg
  • Rename the official extension to be something like talos-vmtoolsd-ext
  • Don't publish image here
@robinelfrink
Copy link
Collaborator

I'd like to keep the package here, as it is also useful in a DaemonSet.

Looking at other extensions in https://github.com/siderolabs/extensions I'd say renaming the image there to simply vmtoolsd sounds most logical.

@frezbo
Copy link
Member Author

frezbo commented Apr 3, 2024

I'd like to keep the package here, as it is also useful in a DaemonSet.

Looking at other extensions in https://github.com/siderolabs/extensions I'd say renaming the image there to simply vmtoolsd sounds most logical.

Cool, I'll get it fixed in extensions. Or even can name vmtools-guest-agent

@frezbo
Copy link
Member Author

frezbo commented Apr 3, 2024

Fixed via: siderolabs/extensions#352

@frezbo frezbo closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants