Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session.__connect_penncnp__ should kill orphaned displays automatically #43

Open
shippy opened this issue Jan 6, 2020 · 3 comments
Open

Comments

@shippy
Copy link
Contributor

shippy commented Jan 6, 2020

Right now, an error is raised with a specific command to run.

We always, always, always end up running the command.

Therefore, just running the call with subprocess.run/subprocess.Popen could save a lot of time here.

@kipohl
Copy link
Contributor

kipohl commented Jan 7, 2020

@shippy if I understand you correctly then lets first talk about it - it might not be the solution

@jimklo
Copy link
Contributor

jimklo commented Jan 7, 2020

I would almost certainly agree with @shippy on this; the only reason not to do this is if we believe there's a race condition where selenium is being used by two threads simultaneously.

Realistically it would make more sense to create a destructor that ensures the process is killed after it goes out of scope - That way the process that launches it is responsible for killing it.

@shippy
Copy link
Contributor Author

shippy commented Jan 9, 2020

See also: #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants