Adding styles for GridSplitter in fluent #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipeshmsft
reviewed
Feb 4, 2025
| <Setter Property="HorizontalAlignment" Value="Stretch" /> | ||
| <Setter Property="VerticalAlignment" Value="Stretch" /> | ||
| <Setter Property="MinHeight" Value="8" /> | ||
| <Setter Property="MinWidth" Value="8" /> |
There was a problem hiding this comment.
I think three should we have GridSplitterMinWidth and GridSplitterMinHeight resources for MinWidth and MinHeight properties ?
| Background="{TemplateBinding Background}"> | ||
| <Rectangle x:Name="PART_Thumb" | ||
| Width="{StaticResource GridsplitterThumbWidth}" | ||
| Height="{StaticResource GridsplitterThumbHeight}" |
There was a problem hiding this comment.
- PART_Thumb Width and Height should have DynamicResource reference
|
I agree with @dipeshmsft comments. Other than that, LGTM :)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A GridSplitter in WPF is a control that allows users to resize rows or columns in a Grid layout interactively. By dragging the splitter, users can adjust the size of adjacent grid sections.
This pull request adds styling for this control in fluent. This style is derived from CommunityTookit SizerBase style.
Fluent:
State: Default
<
State: PointerOver
Customer Impact
Regression
No
Testing
Local build pass
Risk