Skip to content

Commit 5581dec

Browse files
authored
Merge pull request #22 from shuuuuun/fix/options-hash-dup
duplicate option before passing
2 parents ee322ac + 71e9e45 commit 5581dec

File tree

4 files changed

+10
-8
lines changed

4 files changed

+10
-8
lines changed

.github/workflows/main.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,21 @@ jobs:
1818
- name: Set up Ruby
1919
uses: ruby/setup-ruby@v1
2020
with:
21-
ruby-version: 3.1
21+
ruby-version: "3.1"
2222
- name: Install bundler
2323
run: gem install bundler
2424
- name: Setup
2525
run: bin/setup
2626
- name: Rubocop
27-
run: bundle exec rake rubocop
27+
run: bundle exec rubocop --fail-level W
2828
# steep:
2929
# runs-on: ubuntu-latest
3030
# steps:
3131
# - uses: actions/checkout@v2
3232
# - name: Set up Ruby
3333
# uses: ruby/setup-ruby@v1
3434
# with:
35-
# ruby-version: 3.1
35+
# ruby-version: "3.1"
3636
# - name: Install bundler
3737
# run: gem install bundler
3838
# - name: Setup
@@ -44,9 +44,9 @@ jobs:
4444
strategy:
4545
matrix:
4646
ruby:
47-
- 2.7
48-
- 3.0
49-
- 3.1
47+
- "2.7"
48+
- "3.0"
49+
- "3.1"
5050
steps:
5151
- uses: actions/checkout@v2
5252
- name: Set up Ruby

lib/activeadmin/menu_tree.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ def setup_menu_options(aa_config)
4444
ActiveAdmin::MenuTree.log_debug("menu_options: #{menu_options.inspect}")
4545
aa_config.namespace :admin do |admin|
4646
admin.build_menu do |menu|
47-
menu_options.each do |options|
48-
menu.add(**options)
47+
menu_options.each do |option|
48+
menu.add(**option.dup)
4949
end
5050
end
5151
end

lib/activeadmin/menu_tree/config.rb

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ def initialize
1313
def menu_tree=(new_value)
1414
raise ActiveAdmin::MenuTree::Error, "Invalid config" unless new_value.is_a? Array
1515

16+
ActiveAdmin::MenuTree.log_debug("menu_tree=: #{new_value.inspect}")
1617
@menu_tree = new_value.map(&:deep_symbolize_keys)
1718
@menu_options = flatten_options(@menu_tree)
1819
end

spec/spec_helper.rb

+1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# frozen_string_literal: true
22

3+
require "active_admin/dsl"
34
require "activeadmin/menu_tree"
45

56
support_files = Dir[File.expand_path("support/**/*.rb", __dir__)]

0 commit comments

Comments
 (0)