Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable Host headers #88

Closed
brokad opened this issue Mar 19, 2022 · 2 comments
Closed

Customizable Host headers #88

brokad opened this issue Mar 19, 2022 · 2 comments
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features

Comments

@brokad
Copy link
Collaborator

brokad commented Mar 19, 2022 •
edited
Loading

Currently the deployment router at the edge will use the value of the Host: header to decide where to route requests and by default will only accept my-project-name.shuttleapp.rs. This is not ideal for self-deployments which are not deployed as a subdomain of shuttleapp.rs.

We could expose a parameter in Shuttle.toml which lets users configure a Host key for their deployment.
@brokad brokad moved this to Considering in Feature Requests Roadmap Mar 19, 2022
@christos-h christos-h added T-Improvement Improvement or addition to existing features self-deployment labels Apr 5, 2022
@tomkarw
Copy link

tomkarw commented Jun 12, 2023

Is this up for grabs? I could give it a go.

@jonaro00 jonaro00 added S-Triage Awaiting decision for what to do and removed self-deployment labels Aug 17, 2023
@jonaro00
Copy link
Member

Closing in favour of #1563 #1584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-Triage Awaiting decision for what to do T-Improvement Improvement or addition to existing features
Projects
No open projects
Feature Requests Roadmap
Status: Considering
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brokad @christos-h @tomkarw @jonaro00