feat(user-tenant-service):add idp controller to manage users in user tenant service #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surbhi-sharma1
changed the title
yeshamavani
requested changes
Dec 17, 2024
There was a problem hiding this comment.
why are we over populating same service class to communicate with different services
move to a separate service class file
| @@ -133,3 +134,16 @@ export interface IValue { | |||
| name: string; | |||
| value: number | string | boolean; | |||
| } | |||
| export type ConfigureIdpFunc<T> = (payload: IdpDetails) => Promise<T>; | |||
|
|
|||
| export interface IdpDetails { | |||
There was a problem hiding this comment.
why anyObject
and also a model is defined named IdpDetails so why an interface also
cant we use any one
| import {UserCredentialsRepository} from '@sourceloop/user-tenant-service'; | ||
| import {repository} from '@loopback/repository'; | ||
|
|
||
| const basePath = '/idp/users'; |
Comment on lines
56
to
72
| }; | ||
| switch (payload.tenant.identityProvider) { | ||
| case IdPKey.COGNITO: | ||
| break; | ||
| case IdPKey.KEYCLOAK: | ||
| res = await this.idpKeycloakProvider(payload); | ||
| await this.userCredentialsRepository.create({ | ||
| authProvider: 'keycloak', | ||
| password:res.authSecret, | ||
| userId: res.authId, | ||
| }); | ||
| break; | ||
| default: | ||
| break; | ||
| } | ||
| return res; | ||
| } |
There was a problem hiding this comment.
why not returning directly from the switch case ??
| const token = await this.authenticateAdmin(); | ||
|
|
||
| // Fetch the clientId, clientSecret, and realmName from AWS SSM | ||
| const clientId = process.env.KEYCLOAK_CLIENT_ID as string; |
There was a problem hiding this comment.
add the new env variables to env.example file
Surbhi-sharma1
force-pushed
the
GH-38
branch
from
cdbc244 to
be1f633
Compare
resolve comments GH-38
Surbhi-sharma1
force-pushed
the
GH-38
branch
from
be1f633 to
71c50fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add idp controller to manage users in user tenant service
Fixes #38
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: