Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using collapse function the days numbers doesn't show #7

Closed
Ahmed-Abdelmeged opened this issue Apr 15, 2018 · 10 comments
Closed

Comments

@Ahmed-Abdelmeged
Copy link

When i call collapsibleCalendarView.collapse(0)
It hide the the days number like this
image

But i want it like normal collapse like the one if i press the button
image

@shrikanth7698
Copy link
Owner

Hey Ahmed, I solved this issue. I am gonna release a new version by tonight. Please use the new version. Thanks

@Ahmed-Abdelmeged
Copy link
Author

Ahmed-Abdelmeged commented Apr 15, 2018

OK another thing also if you can fix will be great.
when call collapsibleCalendarView.selectedDay if the user doesn't selected a day it should return the current day not crash because getSelectedItem = null
And also if you can make the day object implement Parcelable

@shrikanth7698
Copy link
Owner

Hey Ahmed, Thanks for pointing this out. I fixed this issue.

@Ahmed-Abdelmeged
Copy link
Author

Thank you and don't forget the Parcelable :D

@shrikanth7698
Copy link
Owner

yeah sure sure

@shrikanth7698
Copy link
Owner

screen shot 2018-04-15 at 7 11 57 pm

Hey Ahmed, This is what you asked for right?

@shrikanth7698
Copy link
Owner

Hey, Ahmed sorry I made a small mistake. I used stringArray instead of intArray.
I fixed it now.

@Ahmed-Abdelmeged
Copy link
Author

Yes i think so.

@shrikanth7698
Copy link
Owner

I released the new Version.
Go check it out.
And Thank you so much for pointing out this issues!

@Ahmed-Abdelmeged
Copy link
Author

Ahmed-Abdelmeged commented Apr 15, 2018

You are welcome 💃. But small comment why you add 1 to the month number at your code. and small thing if you can release i will be thankful make the day override the equal to and hash code. so if any one want to compare two days. maybe 1.0.1 :DD @shrikanth7698

karangoel16 added a commit to karangoel16/Collapsible-Calendar-View-Android that referenced this issue Nov 5, 2019
…rk_optimization

Added today click listener
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants