Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update benchmark docs to mention divan #157

Open
CrockAgile opened this issue Jan 5, 2025 · 2 comments
Open

update benchmark docs to mention divan #157

CrockAgile opened this issue Jan 5, 2025 · 2 comments

Comments

@CrockAgile
Copy link
Collaborator

A contributor was unclear while working on #154 if divan or criterion was the main benchmark suite (link).

Documentation should call out the current state of the Divan benchmarks, and decisions such as:

  • when to use Divan vs Criterion
  • whether both should be kept
  • if both are kept, how to run only one of them (cargo bench by default will run both)
@Carlyle-Foster
Copy link
Contributor

i'm not very familiar with their differences, i get the impression that divan is more typesafe? the black_box feature also seems useful but maybe criterion does that kind of thing under the hood?

@Carlyle-Foster
Copy link
Contributor

Carlyle-Foster commented Jan 5, 2025

i definitely don't think they're different enough to justify keeping both and duplicating all the benches, which btw are already out of sync. better to flip a coin than keep both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants