You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
selected filters on Default View do get correctly rendered and applied upon reload, but the issue with this approach seems to be that this:
no longer appears upon color selection, but it does appear after filter selection, so if someone doesn't need any filters applied on their custom grid view, just colors, they won't have the option to save the colors to their custom grid view, as it seems like colors aren't getting saved upon selection (not sure why, but I assumed that this should be the case, to behave in the same way upon filter selection), only when the 'Save View as' is clicked.
The text was updated successfully, but these errors were encountered:
Greetings!
As the title is self explanatory, I will proceed with my findings from the brief investigation I had so far.
I believe that the issue stems from inside shkoliar/magento-grid-colors/view/adminhtml/web/js/grid/controls/colors.js, more specifically this part:
As when this part is refactored to:
selected filters on Default View do get correctly rendered and applied upon reload, but the issue with this approach seems to be that this:
no longer appears upon color selection, but it does appear after filter selection, so if someone doesn't need any filters applied on their custom grid view, just colors, they won't have the option to save the colors to their custom grid view, as it seems like colors aren't getting saved upon selection (not sure why, but I assumed that this should be the case, to behave in the same way upon filter selection), only when the 'Save View as' is clicked.
The text was updated successfully, but these errors were encountered: