Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters set on Default View not being displayed upon page reload #3

Open
roby0404 opened this issue Nov 15, 2021 · 0 comments
Open

Comments

@roby0404
Copy link

Greetings!

As the title is self explanatory, I will proceed with my findings from the brief investigation I had so far.

I believe that the issue stems from inside shkoliar/magento-grid-colors/view/adminhtml/web/js/grid/controls/colors.js, more specifically this part:

            storageConfig: {
                namespace: 'current',
                provider: 'ns = ${ $.ns }, index = bookmarks'
            }

As when this part is refactored to:

            storageConfig: {
                name: '${ $.name }_storage',
                provider: 'ns = ${ $.ns }, index = bookmarks'
            },

selected filters on Default View do get correctly rendered and applied upon reload, but the issue with this approach seems to be that this:

Screenshot from 2021-11-15 17-34-34

no longer appears upon color selection, but it does appear after filter selection, so if someone doesn't need any filters applied on their custom grid view, just colors, they won't have the option to save the colors to their custom grid view, as it seems like colors aren't getting saved upon selection (not sure why, but I assumed that this should be the case, to behave in the same way upon filter selection), only when the 'Save View as' is clicked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant