Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch label creation merges wrong shipping labels #125

Open
andrecedik opened this issue Aug 2, 2017 · 1 comment
Open

Batch label creation merges wrong shipping labels #125

andrecedik opened this issue Aug 2, 2017 · 1 comment

Comments

@andrecedik
Copy link
Contributor

When using the batch label creation mode and you want to create a new shipping label for an order that has previously created shipping labels, one of the old labels is being used to get merged into the merged pdf containing "all the shipping labels from this batch process".

2_orders

The first shipping label in the image above is the one create by the batch process. It's a DHL shipping label. The other accordion that's open is the shipping label from UPS that was used to merge it into the merged pdf --> see b93db61c62d9becbf7fe1056db3a3375b040f67f.pdf.

ScreamingDev pushed a commit that referenced this issue Aug 2, 2017
Within a bulk action each labels will be downloaded
and merged into one big PDF.
Some orders already have labels created manually (via edit screen),
so unfortunately a merge contains such "old" labels too.
Therefor the caching of already created labels needs a proper hash
to separate new and old ones even across API versions.

- Hash of URL covers more scenarios than the described one.
- Pay attention that this can lead to much obsolete files over time.
- see github #125 for more
@ScreamingDev
Copy link
Contributor

I just added something that may solve this @andrecedik (directly to the 1.4 branch) .
Please keep this issue open as it is just a hotfix that produces much data from now on.
We need some garbage collection in upcoming versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants