Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: Less redundant data #114

Open
ScreamingDev opened this issue Jul 27, 2017 · 0 comments
Open

Address: Less redundant data #114

ScreamingDev opened this issue Jul 27, 2017 · 0 comments

Comments

@ScreamingDev
Copy link
Contributor

The sender and recipient is parsed while editing an order in the backend,
which was meant to prepare the data for the API properly.
Problem is that this is some kind of redundant data,
it may not be parsed again once the recipient has been changed in the WooCommerce data-set
and it will not be parsed again when interfering shipcloud settings were changed.
We should parse this data on-the-fly
and only store it in on our own when the shop owner made changes to it.
This would keep data clean, redundancy low and makes it easier to apply new/changed algorithms (like splitting street number).


As a shop owner
I want to have shipcloud and WooCommerce in sync
so that I don't need to maintain the addresses twice.

As a shop owner
I want to change shipcloud recipient and loose the sync with WooCommerce
so that my data stays the same and needs to be written down only once.

As the API
I need all mandatory fields filled
so that I can create a label.


  • We may add some error messages while the user changes data and leave a mandatory field blank.
  • Or we may tell the shop owner that the missing data will be merged.
  • see \WC_Shipcloud_Order::get_recipient
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant