Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gen-aem-aws-stack-builder-ami-ids doesn't work for different JDK8 and JDK11 #47

Open
ovlords opened this issue Oct 28, 2021 · 2 comments
Assignees

Comments

@ovlords
Copy link
Contributor

ovlords commented Oct 28, 2021

The 'make gen-aem-aws-stack-builder-ami-ids' populates the same AMIs for JDK8 and JDK11 variants of the profiles. It should be different.

Please also test it to make sure it gets the ami-ids from all component types. I noticed it wasn't finding the ami_id for the Author-Publish-Dispatcher component.

@rJunx
Copy link
Contributor

rJunx commented Nov 10, 2021

There is no amis for redhat JDK8 and JDK 11. Please bake them and try it again.

@cliffano
Copy link
Collaborator

The issue with not finding AMI ID for Author Publish Dispatcher was caused by inexisting AMIs which then causes the value to be set as null. @rJunx has baked the AMIs and the null values have been replaced, e.g. https://github.com/shinesolutions/aem-helloworld-config/pull/52/files#diff-53f9ab841316df5620a4fd3365b5cf8fce3cbafdc55f47fbf9a4d794356bfcb4L7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants