You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
endAuction() function in Auction.sol rely on totalSellReserveAmount >= (IERC20(sellReserveToken).balanceOf(pool) * poolSaleLimit) / 100 condition to set auction state to FAILED_POOL_SALE_LIMIT, this expose this fuction to donnation attack since attacker can send some sellReserveToken to pool to make this condition validated and get auction state set to FAILED_POOL_SALE_LIMIT.
Recumbent Lead Crane
Medium
endAuction()
might suffer from donation attackSummary
endAuction()
function inAuction.sol
rely ontotalSellReserveAmount >= (IERC20(sellReserveToken).balanceOf(pool) * poolSaleLimit) / 100
condition to set auction state toFAILED_POOL_SALE_LIMIT
, this expose this fuction to donnation attack since attacker can send somesellReserveToken
topool
to make this condition validated and get auction state set toFAILED_POOL_SALE_LIMIT
.Root Cause
In
Auction.sol:341-342
https://github.com/sherlock-audit/2024-12-plaza-finance/blob/main/plaza-evm/src/Auction.sol#L341-L342
auction state
FAILED_POOL_SALE_LIMIT
conditionIn
Auction.sol:356
https://github.com/sherlock-audit/2024-12-plaza-finance/blob/main/plaza-evm/src/Auction.sol#L356
Internal Pre-conditions
No response
External Pre-conditions
No response
Attack Path
No response
Impact
This will cause
claimBid()
to revertAuctionFailed()
PoC
No response
Mitigation
Use internal tracking of
sellReserveToken
balance.The text was updated successfully, but these errors were encountered: