Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheerful Flaxen Poodle - blacklisted #1045

Open
sherlock-admin2 opened this issue Jan 23, 2025 · 0 comments
Open

Cheerful Flaxen Poodle - blacklisted #1045

sherlock-admin2 opened this issue Jan 23, 2025 · 0 comments

Comments

@sherlock-admin2
Copy link
Contributor

Cheerful Flaxen Poodle

High

blacklisted

Summary

USDC Blacklist Breaks Auction Settlement and Claims
Title
Critical Settlement Failure Due to USDC Blacklist in Auction Settlement and Claims

Severity
HIGH - Complete loss of funds and broken settlement mechanism

Description
The auction's settlement and claim processes can be permanently disrupted if the beneficiary address or winning bidders are USDC blacklisted, leading to locked funds and failed settlements.

The vulnerability exists in two critical settlement functions:

Auction Settlement:
function endAuction() external onlyPool {
// ... state checks
if (state == State.SUCCEEDED) {
// Transfer all collected USDC to beneficiary
IERC20(buyCouponToken).safeTransfer(beneficiary, IERC20(buyCouponToken).balanceOf(address(this)));
}

as you can see this function directly transfers winner the winning amount if the bidder gets blacklisted after bidding this will cause a revert and failed auctions

Root Cause

https://github.com/sherlock-audit/2024-12-plaza-finance/blob/14a962c52a8f4731bbe4655a2f6d0d85e144c7c2/plaza-evm/src/Auction.sol#L336-L350

Internal Pre-conditions

No response

External Pre-conditions

No response

Attack Path

No response

Impact

Unable to process auctions

PoC

No response

Mitigation

Separate transfer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant