Skip to content

Commit db9d495

Browse files
authored
Merge pull request #329 from shelfio/feature/LOAPI-15-blacklist-msg-and-mpp
LOAPI-15 Added `.msg` and `.mpp` to unsupported filed extensions
2 parents 8a584f8 + a025ec5 commit db9d495

File tree

2 files changed

+23
-15
lines changed

2 files changed

+23
-15
lines changed

src/validations.test.ts

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,24 @@
11
import {canBeConvertedToPDF} from './validations';
22

3-
describe('canBeConvertedToPDF', () => {
4-
it.each`
5-
filename | expected
6-
${'image.jpg'} | ${false}
7-
${'image.mp4'} | ${false}
8-
${'image.mp3'} | ${false}
9-
${'image.wav'} | ${false}
10-
${'image.chm'} | ${false}
11-
${'image.gdoc'} | ${false}
12-
${'image.dwg'} | ${false}
13-
${'image.docx'} | ${true}
14-
${'image.pdf'} | ${true}
15-
`('should return $expected for filename $filename', ({filename, expected}) => {
16-
expect(canBeConvertedToPDF(filename)).toEqual(expected);
17-
});
3+
it.each`
4+
filename
5+
${'document.docx'}
6+
${'document.pdf'}
7+
`('should return true for supported filename $filename', ({filename}) => {
8+
expect(canBeConvertedToPDF(filename)).toEqual(true);
9+
});
10+
11+
it.each`
12+
filename
13+
${'project.mpp'}
14+
${'email.msg'}
15+
${'image.jpg'}
16+
${'video.mp4'}
17+
${'audio.mp3'}
18+
${'sound.wav'}
19+
${'help.chm'}
20+
${'google-doc.gdoc'}
21+
${'drawing.dwg'}
22+
`('should return false for unsupported filename $filename', ({filename}) => {
23+
expect(canBeConvertedToPDF(filename)).toEqual(false);
1824
});

src/validations.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ const UNSUPPORTED_FILE_EXTENSIONS = [
1010
'.gslides',
1111
'.zip',
1212
'.dwg',
13+
'.msg',
14+
'.mpp',
1315
];
1416

1517
export function canBeConvertedToPDF(filename: string): boolean {

0 commit comments

Comments
 (0)