-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLL results #20
Comments
Hi, no worries, here is the explanation https://github.com/shchur/ifl-tpp#mistakes-in-the-old-version |
You can find the original code used for experiments in the paper here https://github.com/shchur/ifl-tpp/tree/original-code |
Hi, can you kindly explain a bit more why we can not divide NLL by the real number of events in the sequence? In a paper you said this number should not depend on the sequence. "In the old code we used to normalize the NLL of each sequence by the number of events --- this was incorrect. When computing NLL for multiple TPP sequences, we are only allowed to divide the NLL by the same number for each sequence." Thanks in advance. |
As a simple example, consider a homogenous Poisson process with rate Without normalization, the likelihood is If we normalize by the LL by If, however, we normalize the NLL for each sequence by the # of events, we get a different LL function, and end up with the wrong MLE estimate, as you can verify yourself This small example demonstrates that normalizing by # of events leads to incorrect estimation of the TPP parameters. |
Thanks for your response. I get it. |
Hi - I was trying your code on Hawkes-1 similar to the https://github.com/shchur/ifl-tpp/blob/master/code/interactive.ipynb file. The NLL on test set is 43.7, but the reported result in the paper 0.52. Could you please clarify if there should be an additional step be done to get the final result.
My apology if this is a naive question, I am very new in the area of TPP!
The text was updated successfully, but these errors were encountered: