Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make release candidate of ShapeShift Snap #79

Open
willyogo opened this issue Apr 14, 2023 · 0 comments
Open

Make release candidate of ShapeShift Snap #79

willyogo opened this issue Apr 14, 2023 · 0 comments
Assignees

Comments

@willyogo
Copy link

willyogo commented Apr 14, 2023

The final version of MM Flask with the v1 Snaps API is 10.29

Consensus asked us to grab the build here and use it to make a release candidate:
https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/41610/workflows/84c03d93-3b9c-476d-bf76-a43585a90e21/jobs/1159003/artifacts

Note: 10.29 is the latest flask version to use MetaMask/snaps#1364

After that, they will schedule a Gap Audit with Conensys Diligence and add the snap to the allowlist.

AC:

  1. A release candidate of the snap is made using MM Flask version 10.29
  2. The release candidate is sent to [email protected]

More context from Montoya:
April 5th, 2023:
Hi Willy, the final version of Flask with the v1 Snaps API is 10.28.1. It will be hitting the extension stores soon but in the meantime you can grab the build here and use it to make the release candidate of the ShapeShift snap: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/41610/workflows/84c03d93-3b9c-476d-bf76-a43585a90e21/jobs/1159003/artifacts

Then I will schedule a gap audit with ConsenSys Diligence and once that is done we can get you into our allowlist.

April 18th, 2023:
Hi ShapeShift team!

You can now use the publicly available release of Flask to prepare your release candidate, 10.28.2: MetaMask/snaps#1348

Please make sure that the snaps CLI is on version 0.30.0 when building.

If you run into any errors, it may be due to some bugs with built in packages that have surfaced in this build. Just let me know and I can check with my engineering team.

May 1, 2023 (in response to "When should we aim to have this done by?"):
I have Diligence on hand ready to do another audit as soon as you have it updated for Flask 10.29, so the sooner the better!

@pastaghost pastaghost self-assigned this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants