Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeepKey emits a lot of events #505

Open
0xApotheosis opened this issue Apr 7, 2022 · 1 comment
Open

KeepKey emits a lot of events #505

0xApotheosis opened this issue Apr 7, 2022 · 1 comment

Comments

@0xApotheosis
Copy link
Contributor

When interacting with a KeepKey via web, the device is noisy - many events are emitted, likely more than is necessary.

This could also be a web issue - TBC.

The screenshot below shows the number of events emitted when connecting a KeepKey and correctly entering a PIN.

Screen Shot 2022-04-07 at 12 55 32 pm

@mrnerdhair
Copy link
Contributor

mrnerdhair commented Apr 7, 2022

Yep. There's an event emitted for each packet send or received to/from the device, and I don't think any of them are actually used. We really need to clean up the way we use EventEmitters in hdwallet, and concretely specify which actual events are intended to be part of the public interface; as is, I think we have to prove definitively these events aren't being used anywhere to consider removing them a non-breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants