New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`wallet.initialize()` and `adapter.initialize()` work inconsistently across wallet implementations #462

Open

mrnerdhair opened this issue Mar 14, 2022 · 0 comments

Labels

tech-debt

Contributor

mrnerdhair commented Mar 14, 2022 •

edited

Loading

The wallet.initialize() and adapter.initialize() functions are typed (and work) inconsistently.

Make initialize() on adapters private and remove unnecessary dummy implementations.
On adapters with do use initialize(), it should consistently turn a reference to a single device into a wallet instance, and pairDevice() should simply retrieve a reference to the default device and delegating the actual wallet creation to initialize().
initialize() on wallets should always return a Promise<boolean>.

Fixed by #431.

The text was updated successfully, but these errors were encountered:

mrnerdhair added the tech-debt label

mrnerdhair linked a pull request

that will close this issue

research: refactor adapter/wallet initialize() #431

Closed

mrnerdhair mentioned this issue

implement WalletConnect (v1) as a dapp option into hdwallet #499

Closed

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment