Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove BTC(Input|Output)ScriptType.Bech32 #427

Closed
wants to merge 1 commit into from
Closed

remove BTC(Input|Output)ScriptType.Bech32 #427

wants to merge 1 commit into from

Conversation

mrnerdhair
Copy link
Contributor

Removes the Bech32 script type, which just does exactly the same thing as SpendWitness.

@vercel
Copy link

vercel bot commented Feb 12, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/shapeshift/hdwallet/BHyZabeTUCZTfEqCqGJQKad8MXBn
✅ Preview: https://hdwallet-git-remove-bech32-shapeshift.vercel.app

@mrnerdhair mrnerdhair mentioned this pull request Feb 12, 2022
Closed
cjthompson
cjthompson approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@cjthompson cjthompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any backward compatibility issues with this? Is Bech32 currently exported? Any idea if any existing or legacy projects use that enum value?

@mrnerdhair
Copy link
Contributor Author

Are there any backward compatibility issues with this? Is Bech32 currently exported? Any idea if any existing or legacy projects use that enum value?

So this is an interesting question. Bech32 is exported, but I looked through axiom and platform-shared, and it doesn't look like they use the export anywhere. Axiom's got its own array of possible scriptType values, which include plenty of other things that aren't on this list too, like eth and a bunch of other coin names, and that does have a bech32 literal but it's used with Osmosis only. That means it should never end up used in any bitcoin context.

@mrnerdhair mrnerdhair added the reopen-later Stuff that's good to go but not a priority at the moment. label Mar 5, 2022
@mrnerdhair mrnerdhair closed this Mar 5, 2022
@mrnerdhair mrnerdhair added this to the Low Priority milestone Mar 5, 2022
@mrnerdhair mrnerdhair mentioned this pull request Mar 14, 2022
Open
@mrnerdhair mrnerdhair linked an issue Mar 17, 2022 that may be closed by this pull request
BTC(Input|Output)ScriptType.Bech32 is redundant and probably broken #461
Open
@mrnerdhair mrnerdhair modified the milestones: Low Priority, hdwallet++ Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjthompson cjthompson cjthompson approved these changes

@0xApotheosis 0xApotheosis 0xApotheosis approved these changes

Assignees
No one assigned
Labels
reopen-later Stuff that's good to go but not a priority at the moment.
Projects
None yet
Milestone
hdwallet++
Development

Successfully merging this pull request may close these issues.

BTC(Input|Output)ScriptType.Bech32 is redundant and probably broken
3 participants
@mrnerdhair @cjthompson @0xApotheosis