Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Native Wallet to Support protocol buffer tendermint tx format #409

Open
BitHighlander opened this issue Feb 3, 2022 · 1 comment
Assignees

Comments

@BitHighlander
Copy link
Contributor

As of v0.40, the
Cosmos SDK uses
Protocol Buffers (also known
as "protobuf")

This prevents any integrator of HDWallet from being able to broadcast signed transactions against a node > v0.40.

A.C. Native Wallet returns a broadcastable protobuf transaction on signed tendermint transactions

@mrnerdhair
Copy link
Contributor

We've already merged part of this, but there are some remaining references to the old packages/hdwallet-native/src/crypto/isolation/adapters/cosmos.ts in hdwallet-native; repurposing this issue to track removal of that and full conversion to the new signing mechanism.

This will also remove our dep on tendermint-tx-builder, finally allowing us to close out shapeshift/lib#139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants