Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Maven workflow #37

Closed
wants to merge 1 commit into from
Closed

Add GitHub Maven workflow #37

wants to merge 1 commit into from

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Jan 7, 2021 •
edited
Loading

Closes #16

This will run a Maven build for every push and every pull request. In case this becomes annoying for separate development branches or draft pull request, it can be restricted to certain branches.

You could also add a separate workflow for deploying to Maven Central, see GitHub Docs article, though for signing artifacts additional modifications will be needed (but I am not familiar with this).

⚠️ Currently the builds are failing (see this run):

/Users/runner/work/Java-Objective-C-Bridge/Java-Objective-C-Bridge/src/main/objectivec/implementation/WLJavaProxy.m:10:10: fatal error: 'JavaNativeFoundation/JavaNativeFoundation.h' file not found
#include <JavaNativeFoundation/JavaNativeFoundation.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/runner/work/Java-Objective-C-Bridge/Java-Objective-C-Bridge/src/main/objectivec/implementation/WLJavaProxy.m:10:10: note: did not find header 'JavaNativeFoundation.h' in framework 'JavaNativeFoundation' (loaded from '/System/Library/Frameworks/JavaVM.framework/Versions/A/Frameworks')
1 error generated.

Do you think the workflow is missing something? I sadly don't think that I am able to solve this.

@Marcono1234 Marcono1234 marked this pull request as draft January 7, 2021 01:03
@shannah
Copy link
Owner

shannah commented Jan 8, 2021

Thanks. used your workflow, but just added the DEVELOPER_DIR environment variable and it seems to work fine now.

@Marcono1234
Copy link
Contributor Author

No problem and thanks for fixing the workflow file. I will close this pull request then.

Maybe it would be good to remove the Travis CI files then as well, since they are not needed anymore?

@Marcono1234 Marcono1234 closed this Jan 9, 2021
@Marcono1234 Marcono1234 deleted the marcono1234/github-workflow branch January 9, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect to travis-CI
2 participants
@Marcono1234 @shannah