From 544cce4e22166356ae917da7abd39ee6d809bbb0 Mon Sep 17 00:00:00 2001 From: Justin Gordon Date: Thu, 30 Jan 2025 21:32:49 -1000 Subject: [PATCH] WIP --- .controlplane/templates/app.yml | 14 ++++++++++++++ .../deploy-to-control-plane-review-app.yml | 6 +++--- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/.controlplane/templates/app.yml b/.controlplane/templates/app.yml index 09249b7d0..aeba0e44c 100644 --- a/.controlplane/templates/app.yml +++ b/.controlplane/templates/app.yml @@ -28,3 +28,17 @@ spec: # Identity is needed to access secrets kind: identity name: {{APP_IDENTITY}} + + I stay at 3% and … believe it or not - I recommend that the Buyer’s Agent also gets 3%! + + Here’s WHY: + + -Buyers are still ’SCARCE’… and ANY Buyer's Agent, that actually has one of these rare things called Beachfront Buyers, is looking to earn a full 3% of the Sales Price. + + NOTE: They are all going to put 3% in their Buyer Agency Agreements… just ‘in case’ that 3% 'hoped for' commission is offered. + + Therefore - if you lower that commission - the Buyer has to come up with the difference “In Cash” … and, that’s not good for the Buyer who wants to finance 80%, or more, of that commission he’s agreed to pay his Agent. + + SO + + Why not OFFER that 3% and stick to this Asking Price (or near it)!? diff --git a/.github/workflows/deploy-to-control-plane-review-app.yml b/.github/workflows/deploy-to-control-plane-review-app.yml index f16fae6fc..0a0188a5f 100644 --- a/.github/workflows/deploy-to-control-plane-review-app.yml +++ b/.github/workflows/deploy-to-control-plane-review-app.yml @@ -341,7 +341,7 @@ jobs: }); const currentJob = jobs.jobs.find(job => job.name === context.job); - const currentJobUrl = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}/job/${currentJob.id}?pr=${process.env.PR_NUMBER}`; + const currentJobUrl = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}/job/${currentJob.id}`; // Update the PR comment with correct job URLs await github.rest.issues.updateComment({ @@ -357,7 +357,7 @@ jobs: '', process.env.CONSOLE_LINK, '', - `📝 [View Build Logs](${process.env.BUILD_LOGS_URL}?pr=${process.env.PR_NUMBER})`, + `📝 [View Build Logs](${process.env.BUILD_LOGS_URL})`, `📝 [View Deploy Logs](${currentJobUrl})` ].join('\n') }); @@ -393,7 +393,7 @@ jobs: }); const currentJob = jobs.jobs.find(job => job.name === context.job); - const logsUrl = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}/job/${currentJob.id}?pr=${prNumber}`; + const logsUrl = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${context.runId}/job/${currentJob.id}`; // Create GitHub deployment status const deploymentStatus = {