-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DASH live stream with subtitle track doesn't show subtitles #6902
Comments
We have supplied additional test instructions and a manifest to |
@joeyparrish moving from email. The details were sent to |
@theodab Did you have a chance to take a look at the details we emailed? |
If more information is required, please let us know. We'd be more than happy to provide additional data wherever we can. Thank you. |
@joeyparrish bringing this back up :) |
Sorry, we haven't had time to work on this.
I recommend you check the following:
This will help you determine if the timestamps are the root of the problem. We can try to guide you further from there. |
Closing due to inactivity. If this is still an issue for you or if you have further questions, the OP can ask shaka-bot to reopen it by including |
Have you read the FAQ and checked for duplicate open issues?
Yes
If the problem is related to FairPlay, have you read the tutorial?
Not related to FairPlay
What version of Shaka Player are you using?
4.9.9
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from
main
?Not sure how to test this
Are you using the demo app or your own custom app?
Custom app
If custom app, can you reproduce the issue using our demo app?
No because of CORS
What browser and OS are you using?
Electron, macOS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
Dynamic manifest, with geo-restrictions, and widevine with auth (from F1 TV), only available during live sessions, otherwise service uses DASH.
repro-case.zip (wasn't able to grab the original manifest, but got the parsed manifest for this one, then fetched a new manifest for the same media, so hopefully this is correct)
What configuration are you using? What is the output of
player.getConfiguration()
?Show JSON
What did you do?
What did you expect to happen?
Subtitles show up (they do in other players, namely Bitmovin)
What actually happened?
No subtitles show up. They are being fetched, parsed, and added but it almost seems like either the timestamp is parsed wrong, or they are not showing outside of the bounds of the segment?
If I disable this code:
shaka-player/lib/text/ttml_text_parser.js
Lines 334 to 338 in 88d2a02
They do show up, just duplicated.
Are you planning send a PR to fix it?
I'm not sure I have the experience with Shaka that requires this.
The text was updated successfully, but these errors were encountered: