Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Time Structure #353

Open
vaage opened this issue Mar 15, 2018 · 3 comments
Open

Create Time Structure #353

vaage opened this issue Mar 15, 2018 · 3 comments
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: code health A code health issue
Milestone

Comments

@vaage
Copy link
Contributor

vaage commented Mar 15, 2018

To make it easier to work with samples and time in general, change time to use a structure similar to:

struct Time {
  int64_t scaled_pts;
  int64_t scaled_dts;
  int64_t timescale;
}
@vaage vaage added flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: code health A code health issue labels Mar 15, 2018
@vaage vaage added this to the Backlog milestone Mar 15, 2018
@rkuroiwa
Copy link

I prefer using flicks, rather than come up with our own media timescale representation.
https://github.com/OculusVR/Flicks

@kqyang
Copy link
Contributor

kqyang commented Mar 16, 2018

SGTM. We may need to extend flick and use a higher resolution number though as flick is not able to handle some high frequency audio, which we may need to support: facebookarchive/Flicks#19.

@vaage
Copy link
Contributor Author

vaage commented Mar 22, 2018

Will will also need to standardize the type used for time between media sample and text sample. One uses signed and the other uses unsigned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: seeking PR We are actively seeking PRs for this; we do not currently expect the core team will resolve this type: code health A code health issue
Projects
None yet
Development

No branches or pull requests

3 participants