From 4cb653606047b086affc111321187c7889fa238a Mon Sep 17 00:00:00 2001 From: Joey Parrish Date: Tue, 12 Mar 2024 13:09:56 -0700 Subject: [PATCH] fix: Fix NPM binary publication (#1371) The default .npmignore would disallow bin/, which contains binaries for our NPM release. Every release before v3.0.3 was missing .npmignore, and therefore had no binaries. These were unusable in NPM, and have been marked as deprecated because of it. Closes #1369 --- .github/workflows/publish-npm.yaml | 1 - npm/.npmignore | 8 ++++++++ npm/prepublish.js | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 npm/.npmignore diff --git a/.github/workflows/publish-npm.yaml b/.github/workflows/publish-npm.yaml index c06547756df..a8172c1797b 100644 --- a/.github/workflows/publish-npm.yaml +++ b/.github/workflows/publish-npm.yaml @@ -44,7 +44,6 @@ jobs: uses: actions/checkout@v4 with: ref: ${{ inputs.tag }} - submodules: recursive - uses: actions/setup-node@v4 with: diff --git a/npm/.npmignore b/npm/.npmignore new file mode 100644 index 00000000000..9d17c9c4d9f --- /dev/null +++ b/npm/.npmignore @@ -0,0 +1,8 @@ +# This file is required for us, even if empty. +# +# The default .npmignore would disallow bin/, which contains binaries for our +# NPM release. Every release before v3.0.3 was missing .npmignore, and +# therefore had no binaries. These were unusable in NPM, and have been marked +# as deprecated because of it. +# +# See also https://github.com/shaka-project/shaka-packager/issues/1369 diff --git a/npm/prepublish.js b/npm/prepublish.js index 57b13049840..b6a2c49eb13 100755 --- a/npm/prepublish.js +++ b/npm/prepublish.js @@ -14,6 +14,7 @@ var commandNames = { }, darwin: { 'x64': 'packager-osx-x64', + 'arm64': 'packager-osx-arm64', }, win32: { 'x64': 'packager-win-x64.exe',