Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libslang.so is duplicated in release archives #5764

Closed
expipiplus1 opened this issue Dec 5, 2024 · 1 comment · Fixed by #5767
Closed

libslang.so is duplicated in release archives #5764

expipiplus1 opened this issue Dec 5, 2024 · 1 comment · Fixed by #5767
Labels
kind:bug something doesn't work like it should

Comments

@expipiplus1
Copy link
Collaborator

expipiplus1 commented Dec 5, 2024 •
edited
Loading

It's present in both lib and lib64

$ cmake --workflow --preset debug

<snip>

$ unzip -l build/dist-debug/slang.zip | grep libslang.so
207093392  01-01-1980 07:30   lib/libslang.so
207093392  01-01-1980 07:30   lib64/libslang.so

we should fix this before the next release
@expipiplus1 expipiplus1 added the kind:bug something doesn't work like it should label Dec 5, 2024
@expipiplus1
Copy link
Collaborator Author

looks like it's caused by this #5674

expipiplus1 added a commit to expipiplus1/slang that referenced this issue Dec 5, 2024
@expipiplus1
Remove duplicate call to install() for libslang
9c09f76 
Closes shader-slang#5764

Also mention other installed targets in cmake config
@expipiplus1 expipiplus1 mentioned this issue Dec 5, 2024
Merged
expipiplus1 added a commit to expipiplus1/slang that referenced this issue Dec 5, 2024
@expipiplus1
Remove duplicate call to install() for libslang
0f5ae1d 
Closes shader-slang#5764

Also mention other installed targets in cmake config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:bug something doesn't work like it should
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate call to install() for libslang expipiplus1/slang
1 participant
@expipiplus1