You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently when you focus on the combobox there is no focus ring. However, if you tab to the combobox (using focus-visible) there is a ring. The goal should be to make the combobox work like the select regarding focus rings.
The problem is that the trigger for the combobox is a button and buttons in shadcn don't have a ring on focus.
The Combobox example does not have the correct classes on the trigger (Button).
The Select component has focus classes on the trigger (Button):
When I add the tailwind focus classes to my combobox it seems to work ok, but not quite the experience as the Select.
Describe the bug
Currently when you focus on the combobox there is no focus ring. However, if you tab to the combobox (using focus-visible) there is a ring. The goal should be to make the combobox work like the select regarding focus rings.
The problem is that the trigger for the combobox is a button and buttons in shadcn don't have a ring on focus.
The Combobox example does not have the correct classes on the trigger (Button).
The Select component has focus classes on the trigger (Button):
When I add the tailwind focus classes to my combobox it seems to work ok, but not quite the experience as the Select.
but maybe you want to have more integrated solution.
Affected component/components
Combobox
How to reproduce
Codesandbox/StackBlitz link
https://ui.shadcn.com/docs/components/combobox
Logs
No response
System Info
Before submitting
The text was updated successfully, but these errors were encountered: