Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks PHP Intelephense #58

Closed
1 task done
ahosker opened this issue Dec 30, 2024 · 1 comment
Closed
1 task done

Breaks PHP Intelephense #58

ahosker opened this issue Dec 30, 2024 · 1 comment

Comments

@ahosker
Copy link

ahosker commented Dec 30, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the Bug

This was a great extension to hide folders/files in the explorer.
However, it also 'hides' those folders/files from other extensions such as PHP Intelephense.
As such the whole code library is reporting errors, as I had the vendor directory, etc..

Steps To Reproduce

Create a Laravel Project.
Install PHP intelephense Extention
Install this Extention.
Hide the vendor directory.
Close/Re-Open the project, Intelephense will highlight many things as broken.

@manifestinteractive
Copy link
Member

Greetings @ahosker

To clarify what this extension does, it is simply a front-end to VS Code's "Explorer Exclude" settings which are normally controlled in JSON ( either as a User setting, Workspace or Folder ).

The behavior you explained is actually expected behavior and has nothing to do with this extension. Utilizing the "Exclude" feature prevents VS Code from even knowing what you excluded exists. This is by design, as it's a way to tell VS Code "Never consider this to be part of my workspace"

So by excluding something that is actually needed, such as the scenario you described, VS Code will have no way of accessing it because it explicitly told it to exclude it from consideration and not something our extension has any control over.

All we do is just make it easier to manage that exclude list without forcing a developer to manage that VS Code setting manually. Having the ability to control the list with that panel is way more helpful, but ya, once you mark something as excluded, it's excluded 100%. That's just how VS Code rolls ;)

Heck, even folks might thing on a node project that they don't need to see a package.json file and try to exclude it, now all their NPM extensions break... well, you just told VS Code to not consider the primary node package as part of the project anymore, of course it broke.

That's gotten me a few times myself, and I created this extension. That Exclude feature in VS Code is serious business. Also 100% why I wanted to make it easier to quickly turn things on/off in that list, which is where this extension came from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants