Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integer Division in Pure Python compressed_segmentation #449

Open
xiuliren opened this issue Feb 19, 2021 · 1 comment
Open

Integer Division in Pure Python compressed_segmentation #449

xiuliren opened this issue Feb 19, 2021 · 1 comment
Labels
bug The code is not performing according to the design or a design flaw is seriously impacting users.

Comments

@xiuliren
Copy link
Member

xiuliren commented Feb 19, 2021

https://github.com/seung-lab/cloud-volume/blob/master/cloudvolume/py_compressed_segmentation.py#L16

current integer division will not work correctly if the mod is 0. For example, 4//2+1 = 3, ceil(4/2)=2

I am not sure whether this is what you want or not. but according to the comment, it seems that.

@william-silversmith
Copy link
Contributor

Hi Jingpeng,

I think this code is not actually doing anything and I should probably remove it at some point. The code that actually works on compressed segmentation is https://pypi.org/project/compressed-segmentation/

It's only under special conditions that the pure python code would ever get called.

@william-silversmith william-silversmith changed the title integer division Integer Division in Pure Python compressed_segmentation May 27, 2021
@william-silversmith william-silversmith added the bug The code is not performing according to the design or a design flaw is seriously impacting users. label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The code is not performing according to the design or a design flaw is seriously impacting users.
Projects
None yet
Development

No branches or pull requests

2 participants