diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-d3network.js b/zeppelin-web/src/app/visualization/builtins/visualization-d3network.js index 749e4344dca..2621413eeef 100644 --- a/zeppelin-web/src/app/visualization/builtins/visualization-d3network.js +++ b/zeppelin-web/src/app/visualization/builtins/visualization-d3network.js @@ -164,25 +164,27 @@ export default class NetworkVisualization extends Visualization { .append(html.join('')); }; + let clickedOnDOMElement; const drag = d3.behavior.drag() .origin((d) => d) - .on('dragstart', function(d) { + .on('dragstart', (d) => { console.log('dragstart'); d3.event.sourceEvent.stopPropagation(); - d3.select(this).classed('dragging', true); + clickedOnDOMElement = d3.event.sourceEvent.target; + d3.select(clickedOnDOMElement).classed('dragging', true); self.force.stop(); }) - .on('drag', function(d) { + .on('drag', (d) => { console.log('drag'); d.px += d3.event.dx; d.py += d3.event.dy; d.x += d3.event.dx; d.y += d3.event.dy; }) - .on('dragend', function(d) { + .on('dragend', (d) => { console.log('dragend'); d.fixed = true; - d3.select(this).classed('dragging', false); + d3.select(clickedOnDOMElement).classed('dragging', false); self.force.resume(); }); diff --git a/zeppelin-web/src/app/visualization/builtins/visualization-table.js b/zeppelin-web/src/app/visualization/builtins/visualization-table.js index a3243abc5ff..3b1870227fa 100644 --- a/zeppelin-web/src/app/visualization/builtins/visualization-table.js +++ b/zeppelin-web/src/app/visualization/builtins/visualization-table.js @@ -364,14 +364,13 @@ export default class TableVisualization extends Visualization { gridApi.colResizable.on.columnSizeChanged(scope, () => { self.persistConfigWithGridState(self.config); }); - gridApi.edit.on.beginCellEdit(scope, function(rowEntity, colDef, triggerEvent) { + gridApi.edit.on.beginCellEdit(scope, (rowEntity, colDef, triggerEvent) => { let textArea = triggerEvent.currentTarget.children[1].children[0].children[0]; textArea.style.height = textArea.scrollHeight + 'px'; - textArea.addEventListener('keydown', function() { - let elem = this; - setTimeout(function() { - elem.style.height = 'auto'; - elem.style.height = elem.scrollHeight + 'px'; + textArea.addEventListener('keydown', () => { + setTimeout(() => { + textArea.style.height = 'auto'; + textArea.style.height = textArea.scrollHeight + 'px'; }); }, 0); });