Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another includePaths bug #55

Open
srg-clearlaunch opened this issue Jun 30, 2016 · 1 comment
Open

Another includePaths bug #55

srg-clearlaunch opened this issue Jun 30, 2016 · 1 comment

Comments

@srg-clearlaunch
Copy link

Hi - Isn't this a bug in the includePaths?
https://github.com/serverless/serverless-optimizer-plugin/blob/master/index.js#L288

Shouldn't it be something like:

let destDir  = (fs.lstatSync(path.join(_this.evt.options.pathDist,p)).isDirectory()) ? destPath : path.dirname(destPath);

That way optimizer will actually find the intended include? If you just use the includePath as written in the s-function then lstat won't find it because its looking for a full path right? (http://linux.die.net/man/2/lstat)

Changing to the above allows a successful deploy for me

@skilledDeveloper
Copy link

Seems to be fixing the issue mentioned here: #49 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants