Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"unescaper" dependency is unnecessary when libudev is not used #247

Open
JonathonReinhart opened this issue Feb 13, 2025 · 2 comments
Open

Comments

@JonathonReinhart
Copy link

The unescaper crate is only used in one function, udev_property_encoded_or_replaced_as_string(), which is guarded by the libudev feature.

However, the unesecaper dependency is not conditional on the libudev feature: Cargo.toml. It is included for all linux builds.

@sirhcel
Copy link
Contributor

sirhcel commented Feb 14, 2025

Thank you @JonathonReinhart! Good catch.

To my understanding, enabling an optional dependency based on a feature of the crate is possible with the "dep:[...]" syntax since Rust 1.60 but not with our current MSRV 1.59. Do you know whether there is a way to get this working with 1.59?

What's the actual hassle you are experiencing with having this unused dependency on board?

@JonathonReinhart
Copy link
Author

JonathonReinhart commented Feb 17, 2025

Do you know whether there is a way to get this working with 1.59?

I'm not sure, I'm not that familiar with Cargo's dependency features.

What's the actual hassle you are experiencing with having this unused dependency on board?

I'm considering importing the serialport crate into Android's vendored repository android-crates-io, which would also require importing the adds a false unescaper dependency. It's not a showstopper, it just an additional chore. requires some manual intervention with the tooling.

Though this isn't as big of a deal as the dependency on older nix (#175).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants