fix: recreate services instances (Fixes #9) #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to gradle starting by default as daemon and many services configured guice singletons, configuration is read only on first gradle run. If these services are not explicitly reset, serenity configuration changes are ignored on subsequent gradle runs. This commit fixes serenity-bdd#9. It instructs guice to recreate many of these services when they are requested instead of reusing them.
|
Notice that this is a workaround and that it would be probably better if we used guice scopes to control the lifecycle of the instances. I also have to admit that I couldn't understand the code to the point where I could have proposed a more performant solution. Recreating all these instances each time they are needed will have an impact on big projects. |
|
Important: this commit requires serenity-bdd/serenity-core@c2bcb25, but this commit is currently only in master. |
|
I'm experiencing more issues with this PR. I'm closing it for the moment until I see it clearer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to gradle starting by default as daemon and many services configured guice singletons, configuration is read only on first gradle run. If these services are not explicitly reset, serenity configuration changes are ignored on subsequent gradle runs.
This commit fixes #9. It instructs guice to recreate many of these services when they are requested instead of reusing them.