From 78df252a81019eae2f5e0f5a6f4d40f643852ae0 Mon Sep 17 00:00:00 2001 From: James Shaw Date: Tue, 24 Sep 2024 10:47:31 +0100 Subject: [PATCH] refactor: deprecate RestStepListener (#3540) since it no longer does anything --- .../src/main/java/net/serenitybdd/rest/RestStepListener.java | 4 ++++ .../java/net/serenitybdd/rest/utils/RestReportingHelper.java | 5 ----- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/serenity-rest-assured/src/main/java/net/serenitybdd/rest/RestStepListener.java b/serenity-rest-assured/src/main/java/net/serenitybdd/rest/RestStepListener.java index 8d1787cd0..6829f619b 100644 --- a/serenity-rest-assured/src/main/java/net/serenitybdd/rest/RestStepListener.java +++ b/serenity-rest-assured/src/main/java/net/serenitybdd/rest/RestStepListener.java @@ -2,6 +2,10 @@ import net.thucydides.model.steps.StepListenerAdapter; +/** + * @deprecated With no replacement, since {@code RestStepListener} no longer performs any operations. + */ +@Deprecated(since="4.2.2") public class RestStepListener extends StepListenerAdapter { } diff --git a/serenity-rest-assured/src/main/java/net/serenitybdd/rest/utils/RestReportingHelper.java b/serenity-rest-assured/src/main/java/net/serenitybdd/rest/utils/RestReportingHelper.java index 3441a637f..e83dece18 100644 --- a/serenity-rest-assured/src/main/java/net/serenitybdd/rest/utils/RestReportingHelper.java +++ b/serenity-rest-assured/src/main/java/net/serenitybdd/rest/utils/RestReportingHelper.java @@ -9,7 +9,6 @@ import net.serenitybdd.core.Serenity; import net.serenitybdd.model.rest.RestMethod; import net.serenitybdd.model.rest.RestQuery; -import net.serenitybdd.rest.RestStepListener; import net.serenitybdd.rest.decorators.request.RequestSpecificationDecorated; import net.serenitybdd.rest.event.RecordRestQueryEvent; import net.serenitybdd.rest.filters.FieldsRecordingFilter; @@ -39,10 +38,6 @@ */ public class RestReportingHelper { - public RestReportingHelper() { - getParallelEventBus().registerListener(new RestStepListener()); - } - private static boolean shouldRecordResponseBodyFor(Response result) { final ContentType type = ContentType.fromContentType(result.contentType()); return type != null && (ContentType.JSON == type || ContentType.XML == type