Skip to content

Re-enable compile-fail tests #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dtolnay opened this issue Apr 23, 2019 · 2 comments · Fixed by #1521
Closed

Re-enable compile-fail tests #1513

dtolnay opened this issue Apr 23, 2019 · 2 comments · Fixed by #1521
Labels

Comments

@dtolnay
Copy link
Member

dtolnay commented Apr 23, 2019

Disabled temporarily in #1512 due to libserde now appearing in the nightly sysroot and causing a conflict. We will need to figure out how else to run these tests.

@dtolnay dtolnay added the build label Apr 23, 2019
@dtolnay
Copy link
Member Author

dtolnay commented Apr 23, 2019

I think the solution will involve factoring out the test runner from https://github.com/dtolnay/proc-macro-workshop and dropping compiletest_rs in favor of that. It is a more robust approach based on Cargo rather than direct rustc invocations. I have found that it works very reliably and in particular would not have this class of problem.

Upstream issue: dtolnay/proc-macro-workshop#14

@oli-obk
Copy link
Member

oli-obk commented Apr 23, 2019

Here's the clippy workaround: rust-lang/rust-clippy#4017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants