Skip to content

Combine serde_json and serde_json_tests into one crate #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dtolnay opened this issue Feb 26, 2017 · 1 comment
Closed

Combine serde_json and serde_json_tests into one crate #266

dtolnay opened this issue Feb 26, 2017 · 1 comment
Labels
code quality
Milestone
v1.0

Comments

@dtolnay
Copy link
Member

dtolnay commented Feb 26, 2017

These have been separated historically because it was not possible for serde_json to have an optional dev-dependency on serde_derive (rust-lang/cargo#1596).

Now that serde_derive is not optional, it would be simpler to structure the repo in the way serde_urlencoded does, for example.

cc @nox
@dtolnay dtolnay added this to the v1.0 milestone Apr 11, 2017
@dtolnay dtolnay mentioned this issue Apr 12, 2017
Merged
@dtolnay
Copy link
Member Author

dtolnay commented Apr 12, 2017

Fixed in #302.

@dtolnay dtolnay closed this as completed Apr 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality
Milestone
v1.0
Development

No branches or pull requests
1 participant
@dtolnay