Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monero get_pruned_transactions doesn't validate v2 transactions #644

Open
kayabaNerve opened this issue Jan 14, 2025 · 0 comments
Open

Monero get_pruned_transactions doesn't validate v2 transactions #644

kayabaNerve opened this issue Jan 14, 2025 · 0 comments
Labels
improvement This could be better monero An issue with the Monero library/integration

Comments

@kayabaNerve
Copy link
Member

We can as the get_transactions response does include the prunable hash.

For v1 transactions, the transaction hash isn't defined the same and you do need the pruned data to calculate the TX hash (not the hash of it).

We could also better document the (lack of) verification properties.

@kayabaNerve kayabaNerve added improvement This could be better monero An issue with the Monero library/integration labels Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This could be better monero An issue with the Monero library/integration
Projects
None yet
Development

No branches or pull requests

1 participant