Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle undefined correction factors #14

Open
eseiler opened this issue Jul 12, 2021 · 2 comments
Open

Handle undefined correction factors #14

eseiler opened this issue Jul 12, 2021 · 2 comments

Comments

@eseiler
Copy link
Member

eseiler commented Jul 12, 2021

For certain combinations of parameters, the fp_correction will yield inf.
E.g. for h=2, fpr=0.1, the function collapses at around 355 TB: WolframAlpha Plot

Idea:

  • Set f_h to a high number to discourage splitting (inf is actually a high number :))
@feldroop
Copy link
Member

Do we need to do anything, if the fp_correction already yields inf for the problematic cases?

@eseiler
Copy link
Member Author

eseiler commented Jul 13, 2021

Not really, but it may cause trouble in the future.
It seems to be more a problem of x^y being 0 for any positive x < 1 and large enough y, and not so much that there is no correction factor.

But I haven't looked into it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants