Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter --skip-similarity-preprocessing. #122

Open
Irallia opened this issue Dec 13, 2022 · 1 comment
Open

Add parameter --skip-similarity-preprocessing. #122

Irallia opened this issue Dec 13, 2022 · 1 comment

Comments

@Irallia
Copy link
Collaborator

Irallia commented Dec 13, 2022

Add parameter --skip-similarity-preprocessing instead of --estimate-union and --rearrange-user-bins. Set it as
advanced.
If --max-rearrangement-ratio 1, then --rearrange-user-bins should be off, so the flag is not necessary.

@smehringer
Copy link
Member

smehringer commented Dec 14, 2022

One thing that I just noticed:

What happens if --skip-similarity-preprocessing is set but --max-rearrangement-ratio is NOT 1. This would somehow mean that I want --rearrange-user-bins but not --estimate-union which is not possible.

EDIT: Ah I see. --skip-similarity-preprocessing disables both. Then we don't have this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants