Update Ubuntu plugin to use newer version of libpq libraries - release to Bonsai

[mgibson323]

To help improve compatibility with latest versions of Postgres on Ubuntu the plugin should be updated with libpq 10+.

Once updated, please release to Bonsai.

(Follow up to #157)

[lrosenman]

Also look into having a non-nil default for -T / --timeout in all the scripts. libpq12+ breaks the scripts on libpq 12.

[lrosenman]

Note also, libpq is always able to talk to lower releases. I.E. this should be built with the latest libpq from the latest release from PGDG.

[jspaleta]

Note 1: There is no ubuntu asset. there is at best a debian platform_family asset

Note 2: ongoing work to refactor is here:
https://github.com/sensu-plugins/sensu-plugins-postgres/tree/js/update-asset-libpq12

Dockerfiles controlling the asset build are found in the directory asset_build_scripts/
Debian platform_family asset build is controlled by Dockerfile.debian file and is making use of the upstream repository:
http://apt.postgresql.org/pub/repos/apt/

Which I thought was best practice and would provide latest libpq.

I guess the question is.. why is the upstream repository not offering the latest libpq12?
I'm not a debian user, so I may be getting the packaging commands wrong. Input from a debian user on how to ensure that the most recent libpq packages from the upstream repository are being pulled would be appreciated.

[lrosenman]

Debian's packages are generally behind PGDG's releases.

I personally pull from the apt repo referenced here:
https://wiki.postgresql.org/wiki/Apt

[lrosenman]

PostgreSQL 13 is the latest release, and 14 is starting the release process, for what it's worth.

[jspaleta]

I didnt say debian's packages I said postgresl.org's packages FOR debian

[jspaleta]

This is the file in question. Please review the packaging commands being used to setup the posgresql.org apt repository and then install libpq-dev package:
https://github.com/sensu-plugins/sensu-plugins-postgres/blob/js/update-asset-libpq12/asset_build_scripts/Dockerfile.debian

I have no idea why using the best practice postgresl.org repository isn't pulling a recent enough libpq version. My understanding is this is the correct source to use.

[lrosenman]

you want the libpq5 package:

postgres@postgresql-slave-000:/usr/lib/x86_64-linux-gnu$ dpkg-query -S pwd/libpq.so.5.13
libpq5:amd64: /usr/lib/x86_64-linux-gnu/libpq.so.5.13
postgres@postgresql-slave-000:/usr/lib/x86_64-linux-gnu$

[lrosenman]

sorry for not reading clearly :)

[jspaleta]

thanks
I'll update the file and rebuild the test debian family asset in the testing bucket.

[lrosenman]

Can you also look into the -T / --timeout thing with nil, which breaks with the later libpq's?

[jspaleta]

If you can suggest I reasonable default to replace nil to test I can change it.

[lrosenman]

I'd say 10-30 seconds. If PostgreSQL doesn't respond in that time, there's something wrong, IMO.

[jspaleta]

I'll open a separate branch with that change. In the meantime can you test and see if explicit use of the --timeout option as an argument works with the next test asset?

[lrosenman]

using -T 10 works with the current test asset, that's how I got around it yesterday.