metrics-es-node-graphite.rb outputs malformed lines for fs_stats

[fsniper]

The following lines are incompatible with carbon input.

ip-10-0.ec2.internal.elasticsearch.fs.io_stats.devices {"device_name"=>"xvde", "operations"=>10943, "read_operations"=>0, "write_operations"=>10943, "read_kilobytes"=>0, "write_kilobytes"=>72228} 1498828727
ip-10-0-3-169.ec2.internal.elasticsearch.fs.io_stats.total {"operations"=>10943, "read_operations"=>0, "write_operations"=>10943, "read_kilobytes"=>0, "write_kilobytes"=>72228} 1498828727

These json values should be seperated into multiple lines like

ip-10-0.ec2.internal.elasticsearch.fs.io_stats.devices.xvde.operations 10233 1498828727
ip-10-0.ec2.internal.elasticsearch.fs.io_stats.devices.xvde.write_operations 1023 1498828727
ip-10-0.ec2.internal.elasticsearch.fs.io_stats.devices.xvde.read_kilobytes 1023 1498828727
ip-10-0.ec2.internal.elasticsearch.fs.io_stats.devices.xvde.write_kilobytes 1023 1498828727

[majormoses]

@fsniper thanks for reporting, can you give us a little bit more information on the following:

• version of sensu
• version of elasticsearch
• anything else that is relevant about your setup

[fsniper]

sensu version: sensu-0.29.0-11.el7
elasticsearch version:

  "version" : {
    "number" : "5.3.0",
    "build_hash" : "3adb13b",
    "build_date" : "2017-03-23T03:31:50.652Z",
    "build_snapshot" : false,
    "lucene_version" : "6.4.1"
  },

Elastic search is running as a dc/os service

[majormoses]

@fsniper just to confirm (my guess is yes) do you see this when using 0.28 (or test locally with ruby 2.3) or lower? 0.29 (yes there will soon be a 1.x release and sensu will start following semver) had a lot of breaking changes centered around the ruby bump from 2.3 to 2.4 (languages never follow semver and minor versions have breaking changes) so I am recommending that you pin to 0.28 until the plugins can officially support the newer version. We will be making a community announcement soon that the plugins are going into maintenance mode and will not be looking to fix any one off issues with version 0.29 until we have had the time to run through all the plugins and do some testing and officially open support for 0.29 back up.

[fsniper]

This is from 0.29. Do you think these are caused by 0.29? @majormoses

[majormoses]

It's possible though I honestly think it's unlikely, can you try running the same command locally with ruby 2.3 to rule out issues with ruby 2.4?

[cyrilgdn]

We have the same issue with Ruby 2.3 and sensu-plugins-elasticsearch 1.8.0