Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #73

Open
eheydrick opened this issue May 8, 2017 · 2 comments
Open

Add tests #73

eheydrick opened this issue May 8, 2017 · 2 comments
Assignees
@eheydrick

Comments

@eheydrick
Copy link
Contributor

We should add tests for these plugins. This will help catch issues that arise when Elasticsearch makes breaking changes. It will also ensure quality when we make changes, such as a change to the elasticsearch gem version. The tests should be executed against all versions of ES that we support, which is currently 1.x, 2.x, and 5.x.
@eheydrick eheydrick self-assigned this May 8, 2017
@majormoses
Copy link
Member

I would say that ES has EOL 1.x so we should drop support on it and we should focus on 2.x and 5.x: #48 (comment)

@majormoses majormoses reopened this May 9, 2017
@majormoses
Copy link
Member

oops accidental close...

@eheydrick eheydrick mentioned this issue Jul 26, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eheydrick eheydrick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eheydrick @majormoses