-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task: Allow Null ScriptLines #219
Comments
Hi @ibevers, I'm sorry to hear about the issues with ScriptLine initialization. Could you share more details about the scenario you're working on? I'm trying to understand when you might encounter a script with no text or speaker |
@fabiocat93 I wanted to create a null ScriptLine for forced alignment and then populate it with chunks iteratively. I used dicts and then converted the top level dict to ScriptLine at the end instead |
should we close this issue then? |
@fabiocat93 That depends. Is there a strong reason to prevent creation of null ScriptLines? Disallowing them doesn't align with standard Python object creation behavior, where creating null objects is generally allowed. Using dicts like I did is less clean than starting with a ScriptLine and populating it |
Description
I am finding it inconvenient to implement something because I can't initialize a null ScriptLine and iteratively add to it.
Tasks
Freeform Notes
No response
The text was updated successfully, but these errors were encountered: