Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Allow Null ScriptLines #219

Open
1 task done
ibevers opened this issue Dec 11, 2024 · 4 comments · May be fixed by #220
Open
1 task done

Task: Allow Null ScriptLines #219

ibevers opened this issue Dec 11, 2024 · 4 comments · May be fixed by #220
Assignees
Labels
bug Something isn't working

Comments

@ibevers
Copy link
Collaborator

ibevers commented Dec 11, 2024

Description

I am finding it inconvenient to implement something because I can't initialize a null ScriptLine and iteratively add to it.

Tasks

  • Change validation to allow creation of null ScriptLine objects

Freeform Notes

No response

@ibevers ibevers self-assigned this Dec 11, 2024
@ibevers ibevers linked a pull request Dec 11, 2024 that will close this issue
4 tasks
@fabiocat93 fabiocat93 added the bug Something isn't working label Dec 23, 2024
@fabiocat93 fabiocat93 moved this to In Progress in senselab Dec 23, 2024
@fabiocat93
Copy link
Collaborator

Hi @ibevers, I'm sorry to hear about the issues with ScriptLine initialization. Could you share more details about the scenario you're working on? I'm trying to understand when you might encounter a script with no text or speaker

@ibevers
Copy link
Collaborator Author

ibevers commented Dec 23, 2024

@fabiocat93 I wanted to create a null ScriptLine for forced alignment and then populate it with chunks iteratively. I used dicts and then converted the top level dict to ScriptLine at the end instead

@fabiocat93
Copy link
Collaborator

@fabiocat93 I wanted to create a null ScriptLine for forced alignment and then populate it with chunks iteratively. I used dicts and then converted the top level dict to ScriptLine at the end instead

should we close this issue then?

@ibevers
Copy link
Collaborator Author

ibevers commented Dec 23, 2024

@fabiocat93 That depends. Is there a strong reason to prevent creation of null ScriptLines?

Disallowing them doesn't align with standard Python object creation behavior, where creating null objects is generally allowed. Using dicts like I did is less clean than starting with a ScriptLine and populating it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants