From 90047f2343f9f1f44508a90ea2a98051cc2a0e95 Mon Sep 17 00:00:00 2001 From: fabiocat93 Date: Tue, 17 Sep 2024 21:51:02 +0200 Subject: [PATCH 1/2] adding ubuntu tests as required #2 --- .github/workflows/ubuntu_tests.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ubuntu_tests.yaml b/.github/workflows/ubuntu_tests.yaml index 9929777..176f2c3 100644 --- a/.github/workflows/ubuntu_tests.yaml +++ b/.github/workflows/ubuntu_tests.yaml @@ -9,6 +9,8 @@ on: # types: # - completed + + jobs: start-runner: # if: ${{ github.event.workflow_run.conclusion == 'success' }} # Trigger only if macOS tests succeed From 3bbb8581e3e93759ffcc0e53e74051432d1070b7 Mon Sep 17 00:00:00 2001 From: fabiocat93 Date: Tue, 17 Sep 2024 22:55:33 +0200 Subject: [PATCH 2/2] workflow_dispatch --- .github/workflows/macos_tests.yaml | 9 ++++----- .github/workflows/ubuntu_tests.yaml | 21 ++++++++------------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/.github/workflows/macos_tests.yaml b/.github/workflows/macos_tests.yaml index b98bdce..f0d447e 100644 --- a/.github/workflows/macos_tests.yaml +++ b/.github/workflows/macos_tests.yaml @@ -1,12 +1,11 @@ -name: macOS Tests +name: macOS-tests on: - pull_request: - + workflow_dispatch: + jobs: macos-tests: - if: contains(github.event.pull_request.labels.*.name, 'release') - name: macOS Tests + name: macOS-tests runs-on: ${{ matrix.os }} strategy: fail-fast: true diff --git a/.github/workflows/ubuntu_tests.yaml b/.github/workflows/ubuntu_tests.yaml index 176f2c3..bc19167 100644 --- a/.github/workflows/ubuntu_tests.yaml +++ b/.github/workflows/ubuntu_tests.yaml @@ -1,20 +1,15 @@ -name: ubuntu Tests +name: ubuntu-tests on: - pull_request: - -# on: -# workflow_run: -# workflows: ["macOS Tests"] -# types: -# - completed - - + workflow_run: + workflows: ["macOS-tests"] + types: + - completed jobs: start-runner: # if: ${{ github.event.workflow_run.conclusion == 'success' }} # Trigger only if macOS tests succeed - name: Start self-hosted EC2 runner for GPU + name: start-runner runs-on: ubuntu-latest outputs: label: ${{ steps.start-ec2-runner.outputs.label }} @@ -38,7 +33,7 @@ jobs: security-group-id: ${{ vars.AWS_SECURITY_GROUP }} ubuntu-tests: - name: Run GPU Tests on the runner + name: ubuntu-tests needs: start-runner runs-on: ${{ needs.start-runner.outputs.label }} strategy: @@ -89,7 +84,7 @@ jobs: shell: bash stop-runner: - name: Stop self-hosted EC2 runner + name: stop-runner needs: - start-runner # waits for the EC2 instance to be created - ubuntu-tests # waits for the actual job to finish