From bf6d7ccfffda2970cc6eb9bf7c8fec2bdc8d240d Mon Sep 17 00:00:00 2001 From: sburman Date: Thu, 23 Nov 2023 17:49:57 +0530 Subject: [PATCH] test --- packages/client/src/classes/client.js | 2 +- packages/client/src/client.spec.js | 17 ++++++++++++++--- 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/packages/client/src/classes/client.js b/packages/client/src/classes/client.js index 8975ae72..c0c051fe 100644 --- a/packages/client/src/classes/client.js +++ b/packages/client/src/classes/client.js @@ -44,7 +44,7 @@ class Client { setApiKey(apiKey) { this.auth = 'Bearer ' + apiKey; - // this means that region based setter was not called + // this means that region was never set before if (this.sendgrid_region == '') { this.setDefaultRequest('baseUrl', SENDGRID_BASE_URL); } diff --git a/packages/client/src/client.spec.js b/packages/client/src/client.spec.js index 2dfc8a4a..c01106d4 100644 --- a/packages/client/src/client.spec.js +++ b/packages/client/src/client.spec.js @@ -3094,10 +3094,10 @@ describe('test_whitelabel_links__link_id__subuser_post', () => { }); describe('setDataResidency', () => { - const testClient = require('./client'); let consoleWarnSpy; beforeEach(() => { + const testClient = require('./client'); consoleWarnSpy = sinon.spy(console, 'warn'); }); afterEach(() => { @@ -3111,6 +3111,7 @@ describe('setDataResidency', () => { it('should send to host Global/default', () => { testClient.setDataResidency('global'); expect(testClient.defaultRequest.baseUrl).to.equal('https://api.sendgrid.com/'); + expect(testClient.region).to.equal('global'); }); it('should override the existing set hostname, if data residency setter is called after', () => { testClient.setApiKey('SG.1234567890'); @@ -3125,13 +3126,23 @@ describe('setDataResidency', () => { testClient.setDataResidency(null); expect(consoleWarnSpy.calledOnce).to.equal(true); }); - it('should give precedence to the order of execution', () => { + it('setting the API Key wont reset the region set', () => { testClient.setDataResidency('eu'); testClient.setApiKey('SG.1234567890'); - expect(testClient.defaultRequest.baseUrl).to.equal('https://api.sendgrid.com/'); + expect(testClient.defaultRequest.baseUrl).to.equal('https://api.eu.sendgrid.com/'); + expect(testClient.region).to.equal('eu'); }); it('should have default value of hostname as https://api.sendgrid.com/', () => { expect(testClient.defaultRequest.baseUrl).to.equal('https://api.sendgrid.com/'); + expect(testClient.region).to.equal(''); + }); + it('should send to host global and then call setApiKey', () => { + testClient.setDataResidency('global'); + testClient.setApiKey('SG.1234567890'); + expect(testClient.defaultRequest.baseUrl).to.equal('https://api.sendgrid.com/'); + expect(testClient.region).to.equal('global'); + + }); });