fix: Modify condition of checking parent and thread messages (#466)

* Do not check threadInfo to improve the parent message, because every
normal messages potentially can be a parent message
* The type of messageId should be the number

Author: HoonBaek

src/smart-components/Thread/context/ThreadProvider.tsx

@@ -145,7 +145,7 @@ export const ThreadProvider: React.FC<ThreadProviderProps> = (props: ThreadProvi
     sdkInit,
     currentChannel,
     parentMessage,
-  }, { logger, pubSub, threadDispatcher })
+  }, { logger, pubSub, threadDispatcher });
 
   // callbacks
   const fetchPrevThreads = useGetPrevThreadsCallback({

src/smart-components/Thread/context/__test__/utils.spec.ts

@@ -2,20 +2,20 @@ import { UserMessage } from "@sendbird/chat/message";
 import { getParentMessageFrom, isParentMessage, isThreadMessage } from "../utils";
 
 const mockParentMessage = {
-  messageId: 1,
+  messageId: 111111,
   parentMessage: null,
-  parentMessageId: null,
+  parentMessageId: 0,
   threadInfo: {
-    lastRepliedAt: 100000,
+    lastRepliedAt: 1000,
     replyCount: 1,
     mostRepliedUsers: [],
-    updatedAt: 100000,
+    updatedAt: 1000,
   },
 };
 const mockThreadMessage = {
-  messageId: 2,
+  messageId: 111112,
   parentMessage: mockParentMessage,
-  parentMessageId: 1,
+  parentMessageId: 111111,
   threadInfo: null,
 };
 
@@ -26,6 +26,9 @@ describe('Thread/utils - isParentMessage', () => {
   it('should confirm if the message is not a parent message', () => {
     expect(isParentMessage(mockThreadMessage as UserMessage)).toBe(false);
   });
+  it('should check type of the parentMessageId', () => {
+    expect(isParentMessage({ ...mockParentMessage, parentMessageId: '1' } as UserMessage)).toBe(false);
+  });
 });
 
 describe('Thread/utils - isThreadMessage', () => {
@@ -35,6 +38,9 @@ describe('Thread/utils - isThreadMessage', () => {
   it('should comfirm if the message is not a thread message', () => {
     expect(isThreadMessage(mockParentMessage as UserMessage)).toBe(false);
   });
+  it('should check type of the parentMessageId', () => {
+    expect(isThreadMessage({ ...mockThreadMessage, parentMessageId: '1' } as UserMessage)).toBe(false);
+  });
 });
 
 describe('Thread/utils - getParentMessageFrom', () => {

src/smart-components/Thread/context/utils.ts

@@ -25,15 +25,16 @@ export const getParentMessageFrom = (message: UserMessage | FileMessage): UserMe
 export const isParentMessage = (message: UserMessage | FileMessage): boolean => {
   return (
     message?.parentMessage === null
-    && message?.parentMessageId === null
-    && message?.threadInfo !== null
+    && typeof message?.parentMessageId === 'number'
+    && !message?.parentMessageId
   );
 };
 
 export const isThreadMessage = (message: UserMessage | FileMessage): boolean => {
   return (
     message?.parentMessage !== null
-    && message?.parentMessageId !== null
+    && typeof message?.parentMessageId === 'number'
+    && message?.parentMessageId > 0
     && message?.threadInfo === null
   );
 };