Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub fails to calculate file status correctly #82

Open
CodyRay opened this issue Apr 24, 2016 · 0 comments
Open

GitHub fails to calculate file status correctly #82

CodyRay opened this issue Apr 24, 2016 · 0 comments
Assignees
@CodyRay
Labels
bug wontfix

Comments

@CodyRay
Copy link
Member

CodyRay commented Apr 24, 2016

Pull number 961 of libgit2/libgit2sharp demonstrates a bug with GitHub

The file 'LibGit2Sharp/Core/NativeDllName.cs' is actually created with the pull request. However, GitHub reports the file as being modified. This leads us to download an ancestor file that doesn't exist.

I have found no way to fix the cause, so I plan to introduce an IsInvalid flag on files that cannot be downloaded. It will then be ignored in all future analysis.
@CodyRay CodyRay self-assigned this Apr 24, 2016
CodyRay added a commit that referenced this issue Apr 24, 2016
@CodyRay
Handle corner case #82
2302a03 
* Improve error handling with Http errors
* Introduce IsInvalid flag
@CodyRay CodyRay mentioned this issue Apr 24, 2016
Merged
CodyRay added a commit that referenced this issue Apr 24, 2016
@CodyRay
Handle corner case #82
ac932ba 
* Improve error handling with Http errors
* Introduce IsInvalid flag
MRose90 added a commit that referenced this issue Apr 24, 2016
@MRose90
Merge pull request #83 from semdiffdotnet/add_invalid_flag
c2fd129 
Handle corner case #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CodyRay CodyRay

Labels
bug wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CodyRay