Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Artifacts Remain after git checkout #13

Open
smonasco opened this issue Oct 2, 2019 · 0 comments
Open

Artifacts Remain after git checkout #13

smonasco opened this issue Oct 2, 2019 · 0 comments

Comments

@smonasco
Copy link

smonasco commented Oct 2, 2019

I added a new functionality. Some duration formatting utilities for videos. Along with it came a duration-util.test.js file and updates to a test-data.js file. Both in the tests directory.

The duration-util.test.js file is dependent on the changes to the test-data.js file.

After the git checkout the duration-util.test.js file remained though the test-data.js file was rolled back. This caused false positive test errors.

Locally, I added a rm -rf tests line to the index.js file in dist right before the git checkout and it cleaned up my problem.

Since, you are effectively replacing everything in the git checkout list this may be ok as long as some scrubbing occurs to ensure no one is accidentally passing in --paths /,foo, know what I mean? ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant