Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: No callback provied - when running with [email protected] #11

Closed
arlac77 opened this issue Jan 11, 2018 · 4 comments
Closed

Error: No callback provied - when running with [email protected] #11

arlac77 opened this issue Jan 11, 2018 · 4 comments

Comments

@arlac77
Copy link

arlac77 commented Jan 11, 2018

[Semantic release]: An error occurred while running semantic-release: Error: No callback provied.
    at exports.default (/home/travis/build/arlac77/config-expander/node_modules/cracks/dist/index.js:23:11)
    at Object.verifyRelease (/home/travis/build/arlac77/config-expander/node_modules/semantic-release/lib/plugins/normalize.js:41:26)
    at module.exports (/home/travis/build/arlac77/config-expander/node_modules/semantic-release/index.js:41:17)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:160:7)
@pvdlg
Copy link
Member

pvdlg commented Jan 14, 2018

That's because the plugin was not adapted for recent version of semantic-release.
Since v11.0.0 plugins must export and async function instead of a regular one with a callback.

PR welcome to adapt this plugin.

@arlac77
Copy link
Author

arlac77 commented Jan 14, 2018

ok will try my best.
can i drop pre v11.0.0 compatibility and go to a all new version using async/await (maybe using execa)?

@pvdlg
Copy link
Member

pvdlg commented Jan 15, 2018

As far as I'm concerned, yes. Unless someone else has an objection.

geraintwhite added a commit to itsapi/github-listener that referenced this issue Jan 15, 2018
@pvdlg
Copy link
Member

pvdlg commented Oct 1, 2018

Close in favor of #12

@pvdlg pvdlg closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants